feat(witness): use block executor to execute block inside debug_execution_witness #10736
Conversation
There was a problem hiding this comment.
It would be good to start with integrating the block executor into the debug_executionWitness rpc, and then debugging. Is the assert failing due to changes in this PR or does it also occur on main? If it occurs on main, definitely submit an issue and we can focus on it there
0x00101010
force-pushed
the
debug_execution_wintess/block_executor
branch
from
a0d6885 to
0ef0198
Compare
0x00101010
force-pushed
the
debug_execution_wintess/block_executor
branch
from
a7c10ee to
be600b0
Compare
0x00101010
force-pushed
the
debug_execution_wintess/block_executor
branch
2 times, most recently
from
ed3c527 to
abc3d60
Compare
0x00101010
requested review from
mattsse,
emhane,
fgimenez,
onbjerg,
rakita and
gakonst
as code owners
|
@mattsse thoughts on adding executor factory to rpc? |
0x00101010
force-pushed
the
debug_execution_wintess/block_executor
branch
7 times, most recently
from
511b84f to
40a9310
Compare
that makes sense, I assume this could be useful and we could extend this functionality and use this as the entrypoint to abstract execution in rpc in general |
crates/evm/src/test_utils.rs
Outdated
| fn state_ref(&self) -> &State<DB> { | ||
| todo!() | ||
| } |
There was a problem hiding this comment.
this now bakes in the state into the executor interface, I don't want to do this
crates/evm/src/test_utils.rs
Outdated
| @@ -50,7 +51,7 @@ impl<DB> Executor<DB> for MockExecutorProvider { | |||
| type Output = BlockExecutionOutput<Receipt>; | |||
| type Error = BlockExecutionError; | |||
|
|
|||
| fn execute(self, _: Self::Input<'_>) -> Result<Self::Output, Self::Error> { | |||
| fn execute(&mut self, _: Self::Input<'_>) -> Result<Self::Output, Self::Error> { | |||
0x00101010
force-pushed
the
debug_execution_wintess/block_executor
branch
3 times, most recently
from
0b38792 to
f4a5f2c
Compare
crates/rpc/rpc/src/debug.rs
Outdated
| // for (address, account) in bundle_state.state { | ||
| // let hashed_address = keccak256(address); | ||
| // hashed_state.accounts.insert( | ||
| // hashed_address, | ||
| // account.account.as_ref().map(|a| a.info.clone().into()), | ||
| // ); | ||
|
|
||
| // let storage = hashed_state | ||
| // .storages | ||
| // .entry(hashed_address) | ||
| // .or_insert_with(|| HashedStorage::new(account.status.was_destroyed())); | ||
|
|
||
| // if let Some(account) = account.account { | ||
| // if include_preimages { | ||
| // state_preimages | ||
| // .insert(hashed_address, alloy_rlp::encode(address).into()); | ||
| // } | ||
|
|
||
| // for (slot, value) in account.storage { | ||
| // let slot = B256::from(slot); | ||
| // let hashed_slot = keccak256(slot); | ||
| // storage.storage.insert(hashed_slot, value); | ||
|
|
||
| // if include_preimages { | ||
| // state_preimages.insert(hashed_slot, | ||
| // alloy_rlp::encode(slot).into()); } | ||
| // } | ||
| // } | ||
| // } |
There was a problem hiding this comment.
probably should remove this before marking pr ready for review, else mark pr as draft
There was a problem hiding this comment.
Sorry should've changed it to draft before pushing the latest change.
There were further discussion offline regarding the latest update, I'll rework the code to reflect them.
0x00101010
force-pushed
the
debug_execution_wintess/block_executor
branch
from
f4a5f2c to
c256876
Compare
Description
The code does the following:
BlockExecutorProvidertoRpcModuleBuilderand eventually passed down toDebugApiinitializationdebug_execution_witnessAPI to use block_executor to execute blocks.